Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-29 Thread Greg Geldorp
Hi Chip, > From: Charles Davis > > On 10/27/10 8:43 PM, (Marvin) wrote: > > === WINEBUILD (build) === > > Failure running script in VM: Exceeded timeout limit of 300 sec > > Huh? I've never seen that happen before. I can't tell why my patch would > cause this. Ge? Your thoughts? Your patch conta

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-27 Thread Vitaliy Margolen
On 10/27/2010 09:47 PM, Charles Davis wrote: On 10/27/10 9:21 PM, Vitaliy Margolen wrote: On 10/27/2010 07:46 PM, Charles Davis wrote: + /* Now try it on mixed case short names */ What's the point of the test anyway? You know that Wine already handles all files as case-insensitive. Short file

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-27 Thread Charles Davis
On 10/27/10 9:21 PM, Vitaliy Margolen wrote: > On 10/27/2010 07:46 PM, Charles Davis wrote: >> +sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); > Could you please put some spaces after each coma everywhere in your patch? > Please use snprintf(). I was just following the surrounding style. Bu

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-27 Thread Vitaliy Margolen
On 10/27/2010 07:46 PM, Charles Davis wrote: +sprintf(buf,"%s\\%s\\%s",tmpdir,dirname,filename); Could you please put some spaces after each coma everywhere in your patch? Please use snprintf(). +GetShortPathNameA(buf,shortbuf,MAX_PATH); Use sizeof(buf) instead of MAX_PATH to guarante

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-27 Thread Charles Davis
On 10/27/10 8:43 PM, (Marvin) wrote: > Hi, > > While running your changed tests on Windows, I think I found new failures. > Being a bot and all I'm not very good at pattern recognition, so I might be > wrong, but could you please double-check? > Full results can be found at > http://testbot.wineh

Re: [PATCH 3/3] kernel32/tests: Add a test for opening short paths of differing case.

2010-10-27 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=6562 Your paranoid android.