Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Eric Pouech
Le 13/08/2012 09:51, Dmitry Timoshkov a écrit : Eric Pouech wrote: It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) For this particalr patch it means: 1. less code 2.

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Dmitry Timoshkov
Eric Pouech wrote: > > It would look much better without all those 'ret' + 'else' things. > well, wine doesn't have coding guidelines... > so I don't know what "look much better" means (project wise) For this particalr patch it means: 1. less code 2. simpler code 3. more readable code and has

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-13 Thread Eric Pouech
> It would look much better without all those 'ret' + 'else' things. well, wine doesn't have coding guidelines... so I don't know what "look much better" means (project wise) A+ -- Eric Pouech

Re: [PATCH 3/3] [Msacm32]: in acmFormatChoose, added support for template

2012-08-12 Thread Dmitry Timoshkov
Eric Pouech wrote: > MMRESULT WINAPI acmFormatChooseW(PACMFORMATCHOOSEW pafmtc) > { > -return DialogBoxParamW(MSACM_hInstance32, > MAKEINTRESOURCEW(DLG_ACMFORMATCHOOSE_ID), > - pafmtc->hwndOwner, FormatChooseDlgProc, > (LPARAM)pafmtc); > +MMRESULTret; > +