Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-10-10 Thread Kai Blin
On Saturday 10 October 2009 18:18:30 Henri Verbeet wrote: > 2009/10/10 Kai Blin : > > But I highly doubt DirectPlay works on any of those. > > That would be a bug then, although perhaps not the most important one. > > > It's always in intel byteorder. > > That just means the network byte order is l

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-10-10 Thread Henri Verbeet
2009/10/10 Kai Blin : > But I highly doubt DirectPlay works on any of those. That would be a bug then, although perhaps not the most important one. > It's always in intel byteorder. That just means the network byte order is little endian. I agree this isn't the most important thing in a practical

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-10-10 Thread Kai Blin
On Saturday 10 October 2009 12:08:32 Henri Verbeet wrote: > 2009/10/10 Kai Blin : > > Wine runs on architectures with different byte order? I'm not sure if we > > need to be too concerned here. DirectPlay basically sets up a couple of > > structs > > We have at least some level of support for Power

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-10-10 Thread Henri Verbeet
2009/10/10 Kai Blin : > Wine runs on architectures with different byte order? I'm not sure if we need > to be too concerned here. DirectPlay basically sets up a couple of structs We have at least some level of support for PowerPC, SPARC, Alpha and ARM. Probably not something to be overly concerned

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-10-10 Thread Kai Blin
On Tuesday 01 September 2009 11:00:37 Henri Verbeet wrote: I realize I'm a bit late for the party, but anyway: > 2009/9/1 Ismael Barros : > > +typedef struct tagDPSP_MSG_HEADER > > +{ > > +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 > > */ +    SOCKADDR_IN SockAddr; >

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-09 Thread Henri Verbeet
2009/9/9 Ismael Barros² : > - > > #ifdef WORDS_BIGENDIAN > > static inline u_short __dpws_ushort_swap(u_short s) > { >    return (s >> 8) | (s << 8); > } > static inline u_long __dpws_ulong_swap(u_long l) > { >    return ((u_long)__dpws_ushort_swap((u_short)l) << 16) | > __dpws_ushort_s

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-09 Thread Ismael Barros²
On Fri, Sep 4, 2009 at 12:12 PM, Henri Verbeet wrote: > 2009/9/4 Ismael Barros² : >> I've been looking into iphlpapi/ip.h (just learned bit fields >> exist...); would this implementation be fine? >> >> #include "pshpack1.h" >> >> typedef struct tagDPSP_MSG_HEADER >> { >> #ifdef WORDS_BIGENDIAN >>  

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-04 Thread Henri Verbeet
2009/9/4 Ismael Barros² : > I've been looking into iphlpapi/ip.h (just learned bit fields > exist...); would this implementation be fine? > > #include "pshpack1.h" > > typedef struct tagDPSP_MSG_HEADER > { > #ifdef WORDS_BIGENDIAN >    DWORD size:20; >    DWORD token:12; > #else >    DWORD token:12

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-04 Thread Ismael Barros²
On Tue, Sep 1, 2009 at 12:43 PM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros² : >> Is there any standard way to deal with this cases? Any example in the >> codebase? >> > For packing, look for "#include " and "#include > " in some of the headers. For byte ordering look at how > htonl etc. are de

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-01 Thread Henri Verbeet
2009/9/1 Ismael Barros² : > On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: >> 2009/9/1 Ismael Barros : >>> +typedef struct tagDPSP_MSG_HEADER >>> +{ >>> +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ >>> +    SOCKADDR_IN SockAddr; >>> +} DPSP_MSG_HEADER, *LPDPSP

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-01 Thread Ismael Barros²
On Tue, Sep 1, 2009 at 11:00 AM, Henri Verbeet wrote: > 2009/9/1 Ismael Barros : >> +typedef struct tagDPSP_MSG_HEADER >> +{ >> +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ >> +    SOCKADDR_IN SockAddr; >> +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; >> +typedef const DPS

Re: [PATCH 2/7] dpwsockx: Implementation of SPInit

2009-09-01 Thread Henri Verbeet
2009/9/1 Ismael Barros : > +typedef struct tagDPSP_MSG_HEADER > +{ > +    DWORD       size;           /* size & 0x000F, token & 0xFFF0 */ > +    SOCKADDR_IN SockAddr; > +} DPSP_MSG_HEADER, *LPDPSP_MSG_HEADER; > +typedef const DPSP_MSG_HEADER* LPCDPSP_MSG_HEADER; > + It seems you're sending