Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-26 Thread Jacek Caban
On 1/24/11 6:11 PM, Erich Hoover wrote: On Sun, Jan 23, 2011 at 11:32 AM, Jacek Caban wrote: On 1/20/11 6:40 PM, Erich Hoover wrote: On Thu, Jan 20, 2011 at 4:00 AM, Jacek Cabanwrote: +ok(status& success_flag, "OLECMDID_STOP not enabled/supported: %08x\n", status); You could test

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-24 Thread Erich Hoover
On Sun, Jan 23, 2011 at 11:32 AM, Jacek Caban wrote: > On 1/20/11 6:40 PM, Erich Hoover wrote: >> On Thu, Jan 20, 2011 at 4:00 AM, Jacek Caban  wrote: >>> +    ok(status&   success_flag, "OLECMDID_STOP not enabled/supported: >>> %08x\n", status); >>> You could test the exact value here: ok(status

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-23 Thread Jacek Caban
On 1/20/11 6:40 PM, Erich Hoover wrote: On Thu, Jan 20, 2011 at 4:00 AM, Jacek Caban wrote: ... +ok(status& success_flag, "OLECMDID_STOP not enabled/supported: %08x\n", status); You could test the exact value here: ok(status == ...) I was trying to avoid adding some conditional todo_win

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-20 Thread Erich Hoover
On Thu, Jan 20, 2011 at 4:00 AM, Jacek Caban wrote: > ... > +ok(status& success_flag, "OLECMDID_STOP not enabled/supported: %08x\n", > status); > You could test the exact value here: ok(status == ...) I was trying to avoid adding some conditional todo_wine calls (for some reason native does

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-20 Thread Jacek Caban
On 1/19/11 9:31 PM, Erich Hoover wrote: On Wed, Jan 19, 2011 at 1:05 PM, Jacek Caban wrote: On 1/18/11 7:31 PM, Erich Hoover wrote: I've attached a test where I disabled the client/container, and you can see that it then gets passed through (QueryStatusWB will return success instead of pas

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-19 Thread Erich Hoover
On Wed, Jan 19, 2011 at 1:05 PM, Jacek Caban wrote: > On 1/18/11 7:31 PM, Erich Hoover wrote: > >   I've attached a test where I disabled the client/container, and you > > can see that it then gets passed through (QueryStatusWB will return > success instead of passing through the client target and

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-19 Thread Jacek Caban
On 1/18/11 7:31 PM, Erich Hoover wrote: > On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban mailto:ja...@codeweavers.com>> wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is implementing client's IOleCommandTarget. It's something different from document's o

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-18 Thread Erich Hoover
On Tue, Jan 18, 2011 at 3:08 AM, Jacek Caban wrote: > ... > I'm not sure what you mean by "hijack the IOleCommandTarget". All we do is > implementing client's IOleCommandTarget. It's something different from > document's one. I understand that, but apparently the native implementation (testing

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-18 Thread Jacek Caban
On 1/17/11 9:28 PM, Erich Hoover wrote: On Sun, Jan 16, 2011 at 1:01 PM, Jacek Caban wrote: Please write a test case for this. MSDN seems wrong in this case. It indicates in one place that we should use CGID_MSHTML as group GUID, and NULL in the other. The test should make it clean, which ver

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-17 Thread Erich Hoover
On Sun, Jan 16, 2011 at 1:01 PM, Jacek Caban wrote: > On 1/15/11 12:14 AM, Erich Hoover wrote: >> ... >> +    hres = >> IUnknown_QueryInterface(This->doc_host.document,&IID_IOleCommandTarget, >> (LPVOID*)&target); > document may be NULL here. Sorry, I'll take care of that. >> +    hres = IOleC

Re: [PATCH 2/4] shdocvw: Implement IWebBrowser_ExecWB.

2011-01-16 Thread Jacek Caban
Hi Erich, On 1/15/11 12:14 AM, Erich Hoover wrote: Real Name: Erich Hoover Description: Adds support for the IWebBrowser(2)_ExecWB function by passing the requested operations through to IOleCommandTarget_Exec. With this patch (and patch 1) the print button in hhctrl.ocx operates prop