Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.

2012-10-22 Thread Alexandre Julliard
Christian Costa writes: > @@ -599,7 +599,7 @@ static HRESULT WINAPI > IDirectXFileDataImpl_GetId(IDirectXFileData* iface, LPGUID >if (!pGuid) > return DXFILEERR_BADVALUE; > > - memcpy(pGuid, &This->pobj->class_id, 16); > + memcpy(pGuid, &This->pobj->class_id, sizeof(GUID)); Using n

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.

2012-10-21 Thread Christian Costa
Le 21/10/2012 16:21, Rico Schüller a écrit : Why is there a "static guid" used in GetType? What happens if you query: hr = IDirectXFileData_GetType(lpDirectXFileData, &clsid_type); hr = IDirectXFileData_GetType(lpDirectXFileData2, &clsid_type2); Are thy both containing the value to clsid_type2 th

Re: [PATCH 2/2] d3dxof: Use sizeof(GUID) instead of hardcoding the value.

2012-10-21 Thread Rico Schüller
Why is there a "static guid" used in GetType? What happens if you query: hr = IDirectXFileData_GetType(lpDirectXFileData, &clsid_type); hr = IDirectXFileData_GetType(lpDirectXFileData2, &clsid_type2); Are thy both containing the value to clsid_type2 then? Do clsid_type and clsid_type2 match in th