Thanks for the feed back!
I should have went with my gut on these and sent them through
together. They were really meant to all be applied in one go.
Justin
On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote:
> On 2/11/2010 19:51, Justin Chevrier wrote:
>>
>> ---
>> dlls/msctf/langbarmgr.c
On 2/11/10 7:46 PM, Justin Chevrier wrote:
Thanks for the feedback.
Would submitting this as one patch be acceptable?
It's better to split them. It's easy to fix tour patch series. Just run
git rebase -i to reorder and join patches.
Jacek
Thanks for the feedback.
Would submitting this as one patch be acceptable? My intention was
really to have all this applied in one go. If not, I'll split as
recommended.
I've got some fixing up to do and I'll resubmit.
Justin
On Thu, Feb 11, 2010 at 1:27 PM, Justin Chevrier wrote:
> Hi Justin,
Thanks for the feed back!
I should have went with my gut on these and sent them through
together. They were really meant to all be applied in one go.
Justin
On Thu, Feb 11, 2010 at 12:22 PM, Nikolay Sivov wrote:
> On 2/11/2010 19:51, Justin Chevrier wrote:
>>
>> ---
>> dlls/msctf/langbarmgr.c
Hi Justin,
It's good that you're splitting patches, but you did it wrong. No patch may
depend on another patch that is later in series. After applying each patch
the tree must be in good state. That said, Wine won't compile after patch
#1 until patch #6 is applied and patch #2 there will cause
On 2/11/2010 19:51, Justin Chevrier wrote:
---
dlls/msctf/langbarmgr.c | 193 +++
1 files changed, 193 insertions(+), 0 deletions(-)
create mode 100644 dlls/msctf/langbarmgr.c
+This = HeapAlloc(GetProcessHeap(),HEAP_ZERO_MEMORY,sizeof(
