Re: [PATCH 1/7] advapi32: Implement CredWriteW.

2007-11-03 Thread Detlef Riekenberg
On Fr, 2007-11-02 at 13:44 +, Robert Shearman wrote: > > What's the reason of the Parameter "BOOL open_for_write" ? > > > > On the other hand, gcc does not warn about that unused Parameter. "-Wunused" (included in "-Wall") is not enough: We need "-W" with "-Wunused", but wine requires a lot o

Re: [PATCH 1/7] advapi32: Implement CredWriteW.

2007-11-02 Thread Robert Shearman
Detlef Riekenberg wrote: > On Di, 2007-10-30 at 12:36 +, Robert Shearman wrote: > >> +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) >> +{ >> +return RegCreateKeyExW(HKEY_CURRENT_USER, >> wszCredentialManagerKey, 0, >> + NULL, REG_OPTION_NON_VOL

Re: [PATCH 1/7] advapi32: Implement CredWriteW.

2007-11-02 Thread Detlef Riekenberg
On Di, 2007-10-30 at 12:36 +, Robert Shearman wrote: > +static DWORD open_cred_mgr_key(HKEY *hkey, BOOL open_for_write) > +{ > +return RegCreateKeyExW(HKEY_CURRENT_USER, > wszCredentialManagerKey, 0, > + NULL, REG_OPTION_NON_VOLATILE, > +