Re: [PATCH 1/4] msvcp90: Added basic_string::swap implementation. (try 2)

2010-11-15 Thread Piotr Caban
On 11/15/10 18:26, Vincas Miliƫnas wrote: The way I see this is that the code above handles the case when lhs string is in the local buffer and rhs is allocated. The exchange requires copying (lhs->data->buf into rhs->data->buf and rhs->data->ptr into lhs->data->ptr), since setting one's ptr to

Re: [PATCH 1/4] msvcp90: Added basic_string::swap implementation.

2010-11-14 Thread Piotr Caban
On 11/11/10 18:55, Vincas Miliƫnas wrote: This implementation handles cases when basic_strings are allocated using different allocators, however WINE's implementation seems to ignore allocators. It's not ignoring allocators (but it's not setting allocator field). There's no legal way of accessi