Re: [PATCH 1/4] msvcp90: Added basic_string::append(size_t, char) implementation.

2011-04-21 Thread Vincas Miliƫnas
Hi, >It's probably not allowed to use %lc format. Both %c and %lc produce the same trace output: trace:msvcp90:MSVCP_basic_string_wchar_assign_cstr_len 0x32fc20 L"abc" 3 trace:msvcp90:MSVCP_basic_string_wchar_append_len_wchar 0x32fc20 0 z trace:msvcp90:MSVCP_basic_string_wchar_c_str 0x32fc20 trac

Re: [PATCH 1/4] msvcp90: Added basic_string::append(size_t, char) implementation.

2011-04-20 Thread Piotr Caban
Hi, On 04/18/11 23:53, Vincas Miliƫnas wrote: My remark: (The method is implemented by reusing existing code) this->size+countsize is the same as count< 0 and throwing a "string too long" exception in that case is not semantic. count is an unsigned variable so it cannot be smaller then 0. My