2012/12/6 Alexandre Julliard :
> If you can't think of anything to test beyond the handful of cases you
> already have, then you shouldn't be implementing that function. There's
> no hope that your code will be able to cope with invalid input if you
> can't even imagine what invalid input could loo
Alex Henrie writes:
> 2012/12/5 Alexandre Julliard :
>> You have nowhere near enough tests to make such a claim. When I said to
>> write more tests, I didn't mean one or two more. You'd probably need at
>> least 100 tests to have decent coverage of all the interesting cases.
>
> It's not as much
2012/12/5 Alexandre Julliard :
> You have nowhere near enough tests to make such a claim. When I said to
> write more tests, I didn't mean one or two more. You'd probably need at
> least 100 tests to have decent coverage of all the interesting cases.
It's not as much of a technical problem as it i
Alex Henrie writes:
> Far from not addressing any of these issues, I feel that I have
> addressed all of them. More importantly, my implementation is correct;
> it matches Windows XP exactly.
You have nowhere near enough tests to make such a claim. When I said to
write more tests, I didn't mean
David Laight wrote:
> > I think encoding and decoding in UTF-7 arbitrary binary data was
> > considered a "feature" in Windows XP. As MSDN said, "Code written in
> > earlier versions of Windows that rely on this behavior to encode
> > random non-text binary data might run into problems." So I'm s
On Tue, Dec 04, 2012 at 08:30:55PM -0700, Alex Henrie wrote:
> 2012/12/4 Fr?d?ric Delanoy :
> > The above MSDN comment indicates pre-Vista versions are buggy, so it's
> > probably not a good idea to match that behaviour.
>
> I think encoding and decoding in UTF-7 arbitrary binary data was
> consid
Correction: Item 3 should have been "Put the code in kernel32."
-Alex
2012/12/4 Alexandre Julliard :
> Alex Henrie writes:
>
>> My implementation is modeled after Windows XP (Wine's default target
>> Windows version), which encodes and decodes arbitrary character
>> sequences without normalization. I saw that my submission has already
>> been marked "rejected"--was
2012/12/4 Frédéric Delanoy :
> The above MSDN comment indicates pre-Vista versions are buggy, so it's
> probably not a good idea to match that behaviour.
I think encoding and decoding in UTF-7 arbitrary binary data was
considered a "feature" in Windows XP. As MSDN said, "Code written in
earlier ve
Alex Henrie writes:
> My implementation is modeled after Windows XP (Wine's default target
> Windows version), which encodes and decodes arbitrary character
> sequences without normalization. I saw that my submission has already
> been marked "rejected"--was this why?
It was rejected because you
On Tue, Dec 4, 2012 at 5:30 AM, Alex Henrie wrote:
> 2012/12/2 Dmitry Timoshkov :
>> Also you probably need to add support for composition/
>> surrogates like other implementations do.
>
> MSDN states:
>
> "Starting with Windows Vista, this function fully conforms with the
> Unicode 4.1 specificat
2012/12/2 Dmitry Timoshkov :
> Why don't you put it in libs/wine where other unicode conversion routines
> are implemented?
Before I started this project I asked where to put the functions:
http://www.winehq.org/pipermail/wine-devel/2012-January/093705.html
I received no reply, so I put them in l
Alex Henrie wrote:
> I came back to the problem of UTF-7 support and made some improvements
> to my previous submission. The tests are now more stringent, especially
> in regard to null terminator checking, and they test the srclen
> parameter more thoroughly now as well.
>
> I also noticed that
13 matches
Mail list logo
