Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-12 Thread Jacek Caban
On 10/11/12 19:12, Charles Davis wrote: > On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: >> This patch alone makes SunSpider 0.9 17x faster. > Seems to me that something is really wrong with our BSTR implementation if > replacing it with a home-grown implementation speeds this up by a factor of

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Charles Davis
On Oct 11, 2012, at 4:16 AM, Jacek Caban wrote: > This patch alone makes SunSpider 0.9 17x faster. Seems to me that something is really wrong with our BSTR implementation if replacing it with a home-grown implementation speeds this up by a factor of 17. Chip

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Jacek Caban
On 10/11/12 12:39, Henri Verbeet wrote: > On 11 October 2012 12:16, Jacek Caban wrote: >> +struct _jsstr_t { >> +unsigned length_flags; >> +unsigned ref; >> +WCHAR str[1]; >> +}; > It's probably much too late for jscript, and perhaps Wine in general, > but strictly speaking the _t suff

Re: [PATCH 1/4] jscript: Use custom string container instead of BSTR.

2012-10-11 Thread Henri Verbeet
On 11 October 2012 12:16, Jacek Caban wrote: > > +struct _jsstr_t { > +unsigned length_flags; > +unsigned ref; > +WCHAR str[1]; > +}; It's probably much too late for jscript, and perhaps Wine in general, but strictly speaking the _t suffix is reserved by POSIX.