Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.

2008-10-16 Thread Michael Karcher
Am Donnerstag, den 16.10.2008, 15:42 -0500 schrieb Jacek Caban: > > So, I doubt this patch is correct. > This patch fixes regression in Photoshop CS4 installer caused by your > patch. The double free is exactly what happened with your patch and my > patch fixes it. The new root has to be removed

Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.

2008-10-16 Thread Jacek Caban
Michael Karcher wrote: > Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban: > @@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement( > return hr; > > xmlNode = impl_from_IXMLDOMNode( elementNode ); > -xmlDocSetRootElement( get_doc(This), xmlNode->nod

Re: [PATCH 1/3] msxml3: Update orphant list in put_documentElement.

2008-10-16 Thread Michael Karcher
Am Donnerstag, den 16.10.2008, 13:55 -0500 schrieb Jacek Caban: @@ -932,9 +933,17 @@ static HRESULT WINAPI domdoc_put_documentElement( return hr; xmlNode = impl_from_IXMLDOMNode( elementNode ); -xmlDocSetRootElement( get_doc(This), xmlNode->node); + +if(!xmlNode->node->paren