Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alexandre Julliard
Alex Henrie writes: > 2012/9/3 Alexandre Julliard : >> You don't have a single test with an explicit source length, so >> obviously you are not going to find problems in that area. Like I said, >> you need a lot more tests. > > example_2 already tests an explicit source length. In all the other >

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alex Henrie
2012/9/3 Alexandre Julliard : > You don't have a single test with an explicit source length, so > obviously you are not going to find problems in that area. Like I said, > you need a lot more tests. example_2 already tests an explicit source length. In all the other examples srclen = strlen(src) +

Re: [PATCH 1/3] kernel32: Support UTF-7 in MultiByteToWideChar.

2012-09-03 Thread Alexandre Julliard
Alex Henrie writes: > I was asked to split this patch up, so I did. The complaint about the > last version was "You are still overflowing the source." I have not > been able to find any test case that my implementation handled > incorrectly, however, I did find that (*src == 0 && srclen < 0) will