Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

2010-08-18 Thread Mariusz Pluciński
W dniu 18.08.2010 19:34, GOUJON Alexandre pisze: On 08/18/2010 07:06 PM, Mariusz Pluciński wrote: Can I do it by passing __LINE__ macro as parameter to my _validate* functions? Some tests already use __LINE__ as a parameter. See http://source.winehq.org/git/wine.git/?a=blob;f=dlls/advapi32/tes

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

2010-08-18 Thread GOUJON Alexandre
On 08/18/2010 07:06 PM, Mariusz Pluciński wrote: Can I do it by passing __LINE__ macro as parameter to my _validate* functions? Some tests already use __LINE__ as a parameter. See http://source.winehq.org/git/wine.git/?a=blob;f=dlls/advapi32/tests/cred.c#l260 and http://source.winehq.org/git/

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

2010-08-18 Thread Mariusz Pluciński
W dniu 18.08.2010 18:09, Vincent Povirk pisze: I think it would be helpful if you passed a string description to your _validate functions so that in case of failure, you can tell where the original call to _validateGameRegistryKey was, instead of just the line containing the ok() call. Can I do

Re: [PATCH 1/3] gameux: Add definitions of resource identifiers to header file

2010-08-18 Thread Vincent Povirk
> @@ -32,7 +33,6 @@ > > #include "wine/test.h" > > - > static void test_create(BOOL* gameExplorerAvailable, BOOL* > gameExplorer2Available) > { > HRESULT hr; Don't put formatting changes in functional patches, please. I think it would be helpful if you passed a string description to your