Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 12:41, Jacek Caban wrote: > On 04/26/13 12:02, Henri Verbeet wrote: >> On 26 April 2013 10:27, Jacek Caban wrote: >>> - round is not portable. As I mentioned you before, Wine needs to be C89 >>> compatible. If we need some features that are not part of C89, we need >>> to be care

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
On 04/26/13 12:02, Henri Verbeet wrote: > On 26 April 2013 10:27, Jacek Caban wrote: >> - round is not portable. As I mentioned you before, Wine needs to be C89 >> compatible. If we need some features that are not part of C89, we need >> to be careful about that and it often requires things like c

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 10:27, Jacek Caban wrote: > - round is not portable. As I mentioned you before, Wine needs to be C89 > compatible. If we need some features that are not part of C89, we need > to be careful about that and it often requires things like configure > checks. In case of round, replacin

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android