Re: [PATCH 1/2]vbscript: Implemented builtin function CInt

2013-05-21 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25646 Your paranoid android

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt

2013-05-21 Thread Jacek Caban
Hi Zhan, On 05/17/13 16:53, Zhan Jianyu wrote: > This patch is built based on Jaceks's newly-submitted patch: > > commit 48a862306288d69d3623d5ecdc0f5a5a40addafe > ( vbscript: Round half to even in to_int) > > Thanks, Jacek. :-) > > With his patch, CInt could be implementd in a clean way,

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt

2013-05-17 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25604 Your paranoid android

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 12:41, Jacek Caban wrote: > On 04/26/13 12:02, Henri Verbeet wrote: >> On 26 April 2013 10:27, Jacek Caban wrote: >>> - round is not portable. As I mentioned you before, Wine needs to be C89 >>> compatible. If we need some features that are not part of C89, we need >>> to be care

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
On 04/26/13 12:02, Henri Verbeet wrote: > On 26 April 2013 10:27, Jacek Caban wrote: >> - round is not portable. As I mentioned you before, Wine needs to be C89 >> compatible. If we need some features that are not part of C89, we need >> to be careful about that and it often requires things like c

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Henri Verbeet
On 26 April 2013 10:27, Jacek Caban wrote: > - round is not portable. As I mentioned you before, Wine needs to be C89 > compatible. If we need some features that are not part of C89, we need > to be careful about that and it often requires things like configure > checks. In case of round, replacin

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-26 Thread Jacek Caban
Hi Zhan, It's better, thanks, but still needs more work. On 04/25/13 23:37, Zhan Jianyu wrote: > } > > + > + While we're at this, please put more attention into whitespace changes, esp. useless ones. > static HRESULT to_double(VARIANT *v, double *ret) > { > switch(V_VT(v)) { > @@ -217

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 3)

2013-04-25 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25301 Your paranoid android

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)

2013-04-21 Thread Zhan Jianyu
On Sun, Apr 21, 2013 at 11:05 PM, Vincent Povirk wrote: > The man page for modf claims it produces an exact fractional part: > http://manpages.ubuntu.com/manpages/quantal/en/man3/modf.3.html > > It's possible for modf to do this because the fractional part of a > floating point number cannot requi

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)

2013-04-21 Thread Vincent Povirk
The man page for modf claims it produces an exact fractional part: http://manpages.ubuntu.com/manpages/quantal/en/man3/modf.3.html It's possible for modf to do this because the fractional part of a floating point number cannot require more precision than the original value. So I think you've esse

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)

2013-04-20 Thread Zhan Jianyu
Hi. Vincent. The hard part of Banker's Rounding function is to determine if the fractional part is *exactly* 0.5. Thus, to use ceil and floor , one way (for the positive case) is adding 0.5 to a double value, then judge whether the floor of result number equals to the ceil of result number. And

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)

2013-04-20 Thread Vincent Povirk
Dealing with the bits of a floating point number directly is a bit odd, and it makes it hard to review the code. Is there a reason you don't want to use things like modf, floor, and ceil?

Re: [PATCH 1/2]vbscript: Implemented builtin function CInt(try 2)

2013-04-19 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=25204 Your paranoid android