Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient. (try 3)

2012-11-13 Thread Christian Costa
Le 13/11/2012 23:07, Marvin a écrit : Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDet

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient. (try 3)

2012-11-13 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=22927 Your paranoid android

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient.

2012-11-09 Thread Alexandre Julliard
Christian Costa writes: > 2012/11/9 Alexandre Julliard > Testing last error on success is not useful. Also please use > MAKELONG > and related macros instead of doing it by hand. > > I can't use LOWORD as the signed bit is not propagated with & 0x. You could always add a cast, b

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient.

2012-11-09 Thread Christian Costa
2012/11/9 Alexandre Julliard > Christian Costa writes: > > > +SetLastError(0xdeadbeef); > > +n = MapWindowPoints(wnd, NULL, NULL, 0); > > +err = GetLastError(); > > +ok(n == ((window_rect.top << 16) | window_rect.left), "Got %x (%d, > %d), expected %x (%d, %d)\n", > > + n,

Re: [PATCH 1/2] user32: Add tests for MapWindowPoints, ClientToScreen and ScreenToClient.

2012-11-09 Thread Alexandre Julliard
Christian Costa writes: > +SetLastError(0xdeadbeef); > +n = MapWindowPoints(wnd, NULL, NULL, 0); > +err = GetLastError(); > +ok(n == ((window_rect.top << 16) | window_rect.left), "Got %x (%d, %d), > expected %x (%d, %d)\n", > + n, (n << 16) >> 16, n >> 16, window_rect.left,