Re: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-02-08 Thread Henri Verbeet
On 8 February 2013 11:11, Detlef Riekenberg wrote: > I prefer typedef to reduce a bit of typing. > Typedefs aren't meant to be a tool for obfuscation. (Though if you're into that, there are some interesting things you can make the preprocessor do as well.)

Aw: Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-02-08 Thread Detlef Riekenberg
Dimitry wrote: >> +/ >> + * helper for SHGetStockIconInfo >> + */ >> +typedef struct stockiconentry_t { >> + SHSTOCKICONID id; >> + DWORD iconid; >> +} stockiconentry; >Why bother with a typedef? I prefer typedef to red

Re: [PATCH 1/2] shell32: Add a basic implementation for SHGetStockIconInfo

2013-01-30 Thread Dmitry Timoshkov
Detlef Riekenberg wrote: > +/ > + * helper for SHGetStockIconInfo > + */ > +typedef struct stockiconentry_t { > +SHSTOCKICONID id; > +DWORD iconid; > +} stockiconentry; Why bother with a typedef? > +static stock