Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-23 Thread James McKenzie
Anton Khirnov wrote: On Sat, Aug 21, 2010 at 07:50:50PM -0700, James McKenzie wrote: Looks like you did not test the build before running it against the testbot (I've been guilty of this as well.) actually i did test it and it worked for some reason, must be magic :) in any case, after

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread Anton Khirnov
On Sat, Aug 21, 2010 at 07:50:50PM -0700, James McKenzie wrote: > Looks like you did not test the build before running it against the > testbot (I've been guilty of this as well.) > actually i did test it and it worked for some reason, must be magic :) in any case, after rebasing it doesn't -- and

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread James McKenzie
(Marvin) wrote: Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your

Re: [PATCH 1/2] quartz/tests: move shareable code to a separate file

2010-08-21 Thread testbot
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=4626 Your paranoid android.