Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-17 Thread Rob Shearman
2008/10/16 David Laight <[EMAIL PROTECTED]>: > On Wed, Oct 15, 2008 at 04:50:30PM -0500, Jacek Caban wrote: >> Alexandre Julliard wrote: >> >I'd suggest to take advantage of the variant union instead of copying >> >all these glibc definitions. Something like >> > >> >#ifdef NAN >> >V_R8(&vt) =

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-16 Thread David Laight
On Wed, Oct 15, 2008 at 04:50:30PM -0500, Jacek Caban wrote: > Alexandre Julliard wrote: > >I'd suggest to take advantage of the variant union instead of copying > >all these glibc definitions. Something like > > > >#ifdef NAN > >V_R8(&vt) = NAN; > >#else > >V_I8(&vt) = nan_magic_pattern; >

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > Alexandre Julliard wrote: >> I'd suggest to take advantage of the variant union instead of copying >> all these glibc definitions. Something like >> >> #ifdef NAN >> V_R8(&vt) = NAN; >> #else >> V_I8(&vt) = nan_magic_pattern; >> #endif >> > > Th

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Jacek Caban
Alexandre Julliard wrote: I'd suggest to take advantage of the variant union instead of copying all these glibc definitions. Something like #ifdef NAN V_R8(&vt) = NAN; #else V_I8(&vt) = nan_magic_pattern; #endif The problem is that nan_magic_pattern would have to be 8 bytes and AFAI

Re: [PATCH 03/10] jscript: Added NaN value implementation.

2008-10-15 Thread Alexandre Julliard
Jacek Caban <[EMAIL PROTECTED]> writes: > +#include > +#include "basetsd.h" > + > +#ifndef NAN > + > +#ifdef __GNUC__ > + > +# define NAN \ > + (__extension__ > \ > + ((union { unsigned __l __attribute__ ((__mode__ (__SI__))); float