Re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface

2009-11-11 Thread Henri Verbeet
2009/11/10 Owen Rudge : > +static HRESULT WINAPI ImageListImpl_Add(IImageList *iface, HBITMAP hbmImage, > +HBITMAP hbmMask, int *pi) > +{ > +FIXME("STUB: %p %p %p %p\n", iface, hbmImage, hbmMask, pi); > +return E_NOINTERFACE; > +} This is minor at this point, but E_NOTIMPL is usually a

Re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface

2009-11-10 Thread Owen Rudge
is wrong because it changes offsets... but it also breaks those comments. (Can you put the vtable at the end?) In comctl32 v6, IImageList and HIMAGELIST are the same thing. See, for instance, http://msdn.microsoft.com/en-us/library/bb762185%28VS.85%29.aspx: "The IImageList pointer type, suc

re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface

2009-11-10 Thread Dan Kegel
As Nikolay pointed out, the change > /* the ones with offsets at the end are the same as in Windows */ > struct _IMAGELIST > { >+const struct IImageListVtbl *lpVtbl;/* IImageList vtable */ >+LONGref;/* reference count */ >+ > DWORD magic;

Re: [PATCH 02/16] comctl32: Add basic structure for IImageList interface

2009-11-10 Thread Nikolay Sivov
On Wed, Nov 11, 2009 at 12:11 AM, Owen Rudge wrote: > --- >  dlls/comctl32/imagelist.c |  322 > - >  dlls/comctl32/imagelist.h |    3 + >  2 files changed, 319 insertions(+), 6 deletions(-) > After that: --- diff --git a/dlls/comctl32/imagelist.h b/dlls