Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-13 Thread Alexandre Julliard
Charles Davis writes: > On 5/12/10 5:37 PM, Ken Thomases wrote: >> What problems does this cause? > It makes Wine use more memory than it needs to. In theory, but in practice it's not worth the trouble. We used to do this on Linux but it has been removed. It's definitely not worth breaking libwi

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Charles Davis
On 5/12/10 6:10 PM, Ken Thomases wrote: > On May 12, 2010, at 6:53 PM, Charles Davis wrote: > >> On 5/12/10 5:37 PM, Ken Thomases wrote: >>> What problems does this cause? >> It makes Wine use more memory than it needs to. >> >> http://wiki.winehq.org/UnalignedMmap >>> Can't we achieve that just b

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Ken Thomases
On May 12, 2010, at 6:53 PM, Charles Davis wrote: > On 5/12/10 5:37 PM, Ken Thomases wrote: >> What problems does this cause? > It makes Wine use more memory than it needs to. > > http://wiki.winehq.org/UnalignedMmap >> Can't we achieve that just by avoiding the mapping of the "mmap" identifier

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Charles Davis
On 5/12/10 5:37 PM, Ken Thomases wrote: > What problems does this cause? It makes Wine use more memory than it needs to. http://wiki.winehq.org/UnalignedMmap > Can't we achieve that just by avoiding the mapping of the "mmap" identifier > to the _mmap$UNIX2003 symbol? We could for 32-bit, but not

Re: [PATCH 0/2] Unaligned mmap() on Mac OS X

2010-05-12 Thread Ken Thomases
On May 12, 2010, at 2:30 PM, Charles Davis wrote: > In Mac OS X 10.5, mmap() was changed to conform to UNIX '03. Among other > things, this means that mmap() no longer supports unaligned file offsets > (like Linux). What problems does this cause? > However, by reading Darwin source, I learned t