Re: [PATCH] wininet: moved cookie loading from HttpOpenRequest() to HttpSendRequest()

2008-07-03 Thread Yann Droneaud
> On Wednesday 02 July 2008 19:27:43 Yann Droneaud wrote: > >> This patch does the following: >> >> - Move cookie retrieval code to HTTP_HttpSendRequest() >> - Don't allocate memory for url if INTERNET_FLAG_NO_COOKIES is enabled >> - Be sure to not overflow lpszCookies: >> buffer size was nCookie

Re: [PATCH] wininet: moved cookie loading from HttpOpenRequest() to HttpSendRequest()

2008-07-03 Thread Hans Leidekker
On Thursday 03 July 2008 12:18:14 Yann Droneaud wrote: > > Thanks Yann, good to see you move on to fix more bugs. To be accepted > > in git each of those items should be a separate patch though, and the > > impact of moving the cookie code is such that it needs a test case. > > Please, don't ask m

Re: [PATCH] wininet: moved cookie loading from HttpOpenRequest() to HttpSendRequest()

2008-07-03 Thread Hans Leidekker
On Wednesday 02 July 2008 19:27:43 Yann Droneaud wrote: > This patch does the following: > > - Move cookie retrieval code to HTTP_HttpSendRequest() > - Don't allocate memory for url if INTERNET_FLAG_NO_COOKIES is enabled > - Be sure to not overflow lpszCookies: > buffer size was nCookieSize + 1