Re: [PATCH] winepulse: Add pulse driver, v8

2012-03-01 Thread Maarten Lankhorst
Hey Joerg, Op 01-03-12 14:39, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > > Maarten Lankhorst wrote: - Align buffer size to a multiple of period size >>> How can you pass the tests with that? It's wrong with both capture >>> (annoyingly IMHO) and playback. >> I only really need it for

Re: [PATCH] winepulse: Add pulse driver, v8

2012-03-01 Thread Joerg-Cyril . Hoehle
Hi, Maarten Lankhorst wrote: >>> - Align buffer size to a multiple of period size >> How can you pass the tests with that? It's wrong with both capture >> (annoyingly IMHO) and playback. >I only really need it for capture, rendering needs it too since the tests >show that this is the case, >and

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-29 Thread Maarten Lankhorst
Op 29-02-12 17:29, joerg-cyril.hoe...@t-systems.com schreef: > Hi, > > Chris is right about the format. The shared mode mixer ought to return > FLOAT(32), > and it always appears to return the extensible format as a consequence. > For weird reasons, wineoss may return integer formats, but that's c

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-29 Thread Joerg-Cyril . Hoehle
Hi, Chris is right about the format. The shared mode mixer ought to return FLOAT(32), and it always appears to return the extensible format as a consequence. For weird reasons, wineoss may return integer formats, but that's certainly going to cause some unexpecting app to crash. >+assert(old

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-29 Thread Maarten Lankhorst
Hey Chris, Op 29-02-12 06:58, Chris Robinson schreef: > On Tuesday, February 28, 2012 5:32:13 PM Maarten Lankhorst wrote: >> + * This is basically the same as the pa_threaded_mainloop implementation, >> + * but that cannot be used because it uses pthread_create directly >> + * >> + * pa_threaded_m

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-28 Thread Charles Davis
On Feb 28, 2012, at 10:58 PM, Chris Robinson wrote: > On Tuesday, February 28, 2012 5:32:13 PM Maarten Lankhorst wrote: >> + * This is basically the same as the pa_threaded_mainloop implementation, >> + * but that cannot be used because it uses pthread_create directly >> + * >> + * pa_threaded_ma

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-28 Thread Chris Robinson
On Tuesday, February 28, 2012 5:32:13 PM Maarten Lankhorst wrote: > + * This is basically the same as the pa_threaded_mainloop implementation, > + * but that cannot be used because it uses pthread_create directly > + * > + * pa_threaded_mainloop_(un)lock -> pthread_mutex_(un)lock > + * pa_threaded_

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-28 Thread Maarten Lankhorst
Hey Dmitry, Op 28-02-12 18:42, Dmitry Timoshkov schreef: > Maarten Lankhorst wrote: > >> >From 8aa5903b1ee75a6c538d7e1d99560bcb39a47ed2 Mon Sep 17 00:00:00 2001 >> From: Maarten Lankhorst >> Date: Thu, 28 Apr 2011 09:45:18 +0200 >> Subject: [PATCH 10/10] winepulse: Add pulse driver, v8 > You for

Re: [PATCH] winepulse: Add pulse driver, v8

2012-02-28 Thread Dmitry Timoshkov
Maarten Lankhorst wrote: > >From 8aa5903b1ee75a6c538d7e1d99560bcb39a47ed2 Mon Sep 17 00:00:00 2001 > From: Maarten Lankhorst > Date: Thu, 28 Apr 2011 09:45:18 +0200 > Subject: [PATCH 10/10] winepulse: Add pulse driver, v8 You forgot to fix the date, 1 Apr would be more appropriate I'd guess. -