Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff

2010-02-28 Thread Chris Robinson
On Sunday 28 February 2010 11:23:30 pm Marcus Meissner wrote: > A library should be ever built against one model and not change function > ABI depending on a preprocessor define ... This will just break in funny > ways. > > In libmpg123 1.10.0 it does not do evil hacks for me, it has #if 0 around

Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff

2010-02-28 Thread Marcus Meissner
On Sun, Feb 28, 2010 at 03:11:22PM -0800, Chris Robinson wrote: > On Sunday 28 February 2010 1:13:44 pm Marcus Meissner wrote: > > Hi, > > > > Copy in the mpg123.h header from the library so we do not need it for > > building. (it is also LPGL) > > > > Dynamically link from libmpg123.so.0. > > (C

Re: [PATCH] winemp3.acm: always dynamically load libmpg123 stuff

2010-02-28 Thread Chris Robinson
On Sunday 28 February 2010 1:13:44 pm Marcus Meissner wrote: > Hi, > > Copy in the mpg123.h header from the library so we do not need it for > building. (it is also LPGL) > > Dynamically link from libmpg123.so.0. > (Chances are very good that ABI stays stable.) > > This allows me providing a MP3