Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 3)

2013-07-25 Thread Ken Thomases
On Jul 25, 2013, at 10:49 AM, Charles Davis wrote: > Try 3: Don't advertise WGL_EXT_swap_control if vsync is disabled. Looks good. Thanks, Ken

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

2013-07-25 Thread Ken Thomases
On Jul 25, 2013, at 9:57 AM, Ken Thomases wrote: > If vsync is disallowed, the corresponding functions are left as NULL in the > OpenGL function table, so clients may crash if WGL_EXT_swap_control is > advertised. Well, this part is wrong. They won't crash because opengl32 protects against th

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

2013-07-25 Thread Ken Thomases
On Jul 24, 2013, at 9:41 PM, Ken Thomases wrote: > On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > >> Try 2: Don't duplicate a constant string; we might need to add more legacy >> extensions. (Hopefully not. ;) > > Thanks for making that change. Looks good to me. Actually, on further

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string. (try 2)

2013-07-24 Thread Ken Thomases
On Jul 24, 2013, at 9:34 PM, Charles Davis wrote: > Try 2: Don't duplicate a constant string; we might need to add more legacy > extensions. (Hopefully not. ;) Thanks for making that change. Looks good to me. Cheers, Ken

Re: [PATCH] winemac.drv: Advertise some legacy WGL extensions in the GL_EXTENSIONS string.

2013-07-24 Thread Ken Thomases
Hi, On Jul 23, 2013, at 10:26 PM, Charles Davis wrote: > @@ -1226,8 +1227,10 @@ static BOOL init_gl_info(void) > gl_info.glVersion = HeapAlloc(GetProcessHeap(), 0, strlen(str) + 1); > strcpy(gl_info.glVersion, str); > str = (const char*)opengl_funcs.gl.p_glGetString(GL_EXTENSIONS); >