Am 25.01.2012 14:40 schrieb "Andrew Eikum" :
> What about
> changing them to WARN so that they don't print to the console by
> default? Everyone knows there are workarounds, but is anyone really
> gaining anything by having these flood the console?
I agree with this sentiment, althougj Henri's poin
On Wed, Jan 25, 2012 at 02:03:04PM +0100, Henri Verbeet wrote:
> The code looks like it would do what was intended to me. The problem I
> have with it, and I'm pretty sure I've mentioned this before, is that
> reducing debug output shouldn't be a goal on its own. If you're a
> user, and the message
On 25 January 2012 01:25, Francois Gouget wrote:
> I don't pretend to know what Henry meant but reported_once is not
> initialized. It's probably put into a zero-initialized section by the
> compiler but it looks worrying to me (I believe something like this has
> been debated on the Linux kernel
2012/1/25 Nicolas Le Cam :
> 2012/1/25 Francois Gouget :
>> On Wed, 25 Jan 2012, Detlef Riekenberg wrote:
>>
>>> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
>>> > On 22 January 2012 19:44, Detlef Riekenberg wrote:
>>> > > - if (usage & ~handled)
>>> > > + static DWORD reported_on
2012/1/25 Francois Gouget :
> On Wed, 25 Jan 2012, Detlef Riekenberg wrote:
>
>> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
>> > On 22 January 2012 19:44, Detlef Riekenberg wrote:
>> > > - if (usage & ~handled)
>> > > + static DWORD reported_once;
>> > > +
>> > > + if (usage
On Wed, 25 Jan 2012, Detlef Riekenberg wrote:
> On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
> > On 22 January 2012 19:44, Detlef Riekenberg wrote:
> > > -if (usage & ~handled)
> > > +static DWORD reported_once;
> > > +
> > > +if (usage & ~(handled | reported_once))
> > >
On Sun, 2012-01-22 at 19:53 +0100, Henri Verbeet wrote:
> On 22 January 2012 19:44, Detlef Riekenberg wrote:
> > -if (usage & ~handled)
> > +static DWORD reported_once;
> > +
> > +if (usage & ~(handled | reported_once))
> > +{
> > +reported_once |= (usage & ~handled);
> >
On 22 January 2012 19:44, Detlef Riekenberg wrote:
> - if (usage & ~handled)
> + static DWORD reported_once;
> +
> + if (usage & ~(handled | reported_once))
> + {
> + reported_once |= (usage & ~handled);
> FIXME("Unhandled usage flags %#x.\n", usage & ~handled);
> + }
