Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Vincent Povirk wrote: > Yes, it is possible that I wrote more code than was necessary to > support TGA because I knew WIC better and because I thought it'd be > cool (in theory the decoder can now be used outside the context of > d3dx9, for instance on windows with the builtin image viewer - not

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Vincent Povirk
>> > TGA is the simplest format I've ever seen, CreateBitmapFromMemory is >> > the straight way to handle it. I haven't looked at ICNS support, but >> > probably it could be implemented using public APIs as well. >> >> The main reason I put the TGA decoder in WIC is that I know nothing >> about d3d

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > TGA is the simplest format I've ever seen, CreateBitmapFromMemory is > > the straight way to handle it. I haven't looked at ICNS support, but > > probably it could be implemented using public APIs as well. > > The main reason I put the TGA decoder in WIC is that I know

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Vincent Povirk
>> If there's really a demand for using native windowscodecs without >> breaking d3dx9 (which already happens because of the TGA decoder), I >> can supply a win32 build of our WIC extensions that winetricks could >> install with it. I can't do anything about ICNS. > > TGA is the simplest format I'v

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Vincent Povirk wrote: > If there's really a demand for using native windowscodecs without > breaking d3dx9 (which already happens because of the TGA decoder), I > can supply a win32 build of our WIC extensions that winetricks could > install with it. I can't do anything about ICNS. TGA is the si

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Vincent Povirk
If there's really a demand for using native windowscodecs without breaking d3dx9 (which already happens because of the TGA decoder), I can supply a win32 build of our WIC extensions that winetricks could install with it. I can't do anything about ICNS. >> Yes, there are other ways we could do this

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Vincent Povirk wrote: > > I'd suggest to use public APIs instead of inventing "extenstions". > > CreateBitmapFromMemory should work for this purpose if you really need > > to do it using windowscodecs, otherwise GDI APIs may work as well. > > I've been of the opinion that we should have a separa

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Vincent Povirk
> I'd suggest to use public APIs instead of inventing "extenstions". > CreateBitmapFromMemory should work for this purpose if you really need > to do it using windowscodecs, otherwise GDI APIs may work as well. I've been of the opinion that we should have a separate dll for Wine extensions to WIC,

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Christian Costa
Oupsss. I forgot to explain. No it's not it native windowscodecs. It's a wine extension to support DIB files used in d3dx9_36. Everything was already in place. I just had to hook things up. I asked to Vincent who told to do this way. At least it's what I understood. Christian 2013/1/21 Dmitry Tim

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Christian Costa wrote: > Oupsss. I forgot to explain. > No it's not it native windowscodecs. It's a wine extension to support > DIB files used in d3dx9_36. > Everything was already in place. I just had to hook things up. > I asked to Vincent who told to do this way. At least it's what I understoo

Re: [PATCH] windowscodecs: Add support for DIB format.

2013-01-21 Thread Dmitry Timoshkov
Christian Costa wrote: > cpp_quote("DEFINE_GUID(CLSID_WICBmpDecoder, > 0x6b462062,0x7cbf,0x400d,0x9f,0xdb,0x81,0x3d,0xd1,0x0f,0x27,0x78);") > +cpp_quote("DEFINE_GUID(CLSID_WICDibDecoder, > 0x6b462062,0x7cbf,0x400d,0x9f,0xdb,0x81,0x3d,0xd1,0x0f,0x27,0x79);") > cpp_quote("DEFINE_GUID(CLSID_WIC