Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Florian Köberle
On 06/28/2010 01:44 PM, Reece Dunn wrote: > On 28 June 2010 12:26, Alexandre Julliard wrote: > >> Wolfram Sang writes: >> >> >>> According to TestBot (#2851), all non-crashing Windows versions return 0. >>> >>> Found while working on Bug 21012. Although this patch doesn't cure this >>> bu

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Wolfram Sang
On 28/06/10 13:26, Alexandre Julliard wrote: > Wolfram Sang writes: > >> According to TestBot (#2851), all non-crashing Windows versions return 0. >> >> Found while working on Bug 21012. Although this patch doesn't cure this >> bug, I think it is still worth adding the check because the pointer >

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Alexandre Julliard
Reece Dunn writes: > When running winedbg on bfginstaller.exe (trying to track down > http://bugs.winehq.org/show_bug.cgi?id=14343), winedbg will trap in > the cursoricon.c code (line 771 -- > http://source.winehq.org/git/wine.git/?a=blob;f=dlls/user32/cursoricon.c;h=9a1810e22a1a77c698a14e0d6a9a3

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Reece Dunn
On 28 June 2010 12:26, Alexandre Julliard wrote: > Wolfram Sang writes: > >> According to TestBot (#2851), all non-crashing Windows versions return 0. >> >> Found while working on Bug 21012. Although this patch doesn't cure this >> bug, I think it is still worth adding the check because the point

Re: [PATCH] user32: check for valid pointer in CreateIconFromResource

2010-06-28 Thread Alexandre Julliard
Wolfram Sang writes: > According to TestBot (#2851), all non-crashing Windows versions return 0. > > Found while working on Bug 21012. Although this patch doesn't cure this > bug, I think it is still worth adding the check because the pointer > may come from the (always evil ;)) user-application.