Re: [PATCH] user32: check for valid pointer in CURSORICON_CreateIconFromBMI

2010-06-23 Thread Wolfram Sang
On 23/06/10 15:32, Alexandre Julliard wrote: > Wolfram Sang writes: > >> @@ -884,6 +884,10 @@ static HICON CURSORICON_CreateIconFromBMI( BITMAPINFO >> *bmi, >> return 0; >> } >> >> +/* A few Windows versions crash getting NULL, but most simply return it >> */ >> +if (!bm

Re: [PATCH] user32: check for valid pointer in CURSORICON_CreateIconFromBMI

2010-06-23 Thread Alexandre Julliard
Wolfram Sang writes: > @@ -884,6 +884,10 @@ static HICON CURSORICON_CreateIconFromBMI( BITMAPINFO > *bmi, > return 0; > } > > +/* A few Windows versions crash getting NULL, but most simply return it > */ > +if (!bmi) > +return 0; That's not the right place for i