Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-08 Thread Qian Hong
Hello, On Thu, Nov 8, 2012 at 5:53 PM, Dmitry Timoshkov wrote: > What's wrong with having a .reg file with unicode file names and feed > it to reg.exe? Then there is no any need for custom wine.inf patches. Then we have to feed it to reg.exe every time when a new wineprefix created, or did I mis

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-08 Thread Alexandre Julliard
Qian Hong writes: > Since Wine1.4 we added the 'font replacement' feature to Wine, and > leave the 'font replacement' setting to distribution folks, for > example, Ubuntu's Wine packager has a patch like > 0001-tools-wine.inf.in-Added-font-name-replacement.txt A better approach would be to do th

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-08 Thread Dmitry Timoshkov
Qian Hong wrote: > I mean, after splitting into two parts, commit the first part to > upstream Wine, and leave the second part to the distribution folks, > just like what we do for > 0001-tools-wine.inf.in-Added-font-name-replacement.txt right now. What's wrong with having a .reg file with unico

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-08 Thread Qian Hong
On Thu, Nov 8, 2012 at 4:04 PM, Qian Hong wrote: > My idea is split the second patch into two parts, the first part is > 0001-tools-wine.inf.in-Added-UTF8-bom-header.txt, the second part is > adding english and localized font name replacement settings without > changing the encoding of wine.inf.in

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-08 Thread Qian Hong
Hello, On Thu, Nov 8, 2012 at 3:25 AM, Alexandre Julliard wrote: > > It's here to support Unicode data in wine.inf, as you noted. However, I > don't think it makes sense to add the BOM unless we actually have > Unicode keys in there. Thanks for explain! Let me make a summary of Bug 32136: Sinc

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-07 Thread Alexandre Julliard
Qian Hong writes: > However, in git log I see such a commit: > commit 31ade1eb67e6b55f1b0c09ef7a806cd53652b1e2 > Author: Alexandre Julliard > Date: Wed Mar 21 13:52:43 2007 +0100 > > setupapi: Add support for .inf files in utf-8 format. > > Did I miss anything or was there a reason to add

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-07 Thread Qian Hong
Hi Dmitry, On Wed, Nov 7, 2012 at 11:25 AM, Dmitry Timoshkov wrote: > So, how is this supposed to work under Windows? I wrote a test case, to my surprise, Windows doesn't support UTF8 .inf file, no matter with or without BOM. However, Windows support Little-endian UTF-16 Unicode .inf file. The t

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header. (resend)

2012-11-06 Thread Dmitry Timoshkov
Qian Hong wrote: > Added comment as Dan suggested. Thanks Dmitry, Dan and Nikolay for comments > and advice. Also I'm appreciated for any other ideas to resolve Bug 32136. So, how is this supposed to work under Windows? -- Dmitry.

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.

2012-11-06 Thread Qian Hong
Hi Dmitry, On Tue, Nov 6, 2012 at 3:59 PM, Dmitry Timoshkov wrote: > It should be possible to specify a not localized font name. In general, > wine.inf follows Windows format of .inf files, you should investigate > how unicode is supposed to work inside of .inf files. Thanks for advice! Unfortun

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.

2012-11-05 Thread Dmitry Timoshkov
Qian Hong wrote: > Currently wine.inf.in does not contain non ASCII strings, but if we > want to solve Bug 32136, as Comment 4, we need to add some non ASCII > strings to wine.inf.in, such as: > --- snip --- > HKCU,Software\Wine\Fonts\Replacements,"宋体",,"WenQuanYi Micro Hei" > --- snip --- > > M

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.

2012-11-05 Thread Qian Hong
Hi Dmitry, On Tue, Nov 6, 2012 at 12:44 PM, Dmitry Timoshkov wrote: > Qian Hong wrote: > >> This patch solve the wine side of Bug 32136. > > Why is this needed? wine.inf.in doesn't contain non ASCII strings. > Currently wine.inf.in does not contain non ASCII strings, but if we want to solve Bug

Re: [PATCH] tools/wine.inf.in: Added UTF8 bom header.

2012-11-05 Thread Dmitry Timoshkov
Qian Hong wrote: > This patch solve the wine side of Bug 32136. Why is this needed? wine.inf.in doesn't contain non ASCII strings. -- Dmitry.