Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

2011-07-29 Thread Octavian Voicu
On Fri, Jul 29, 2011 at 9:55 AM, Paul Vriens wrote: >> +        win_skip("Not on WOW64, skipping test.\n"); > > Why a win_skip()? Isn't a normal skip() more appropriate? Year, you're right, win_skip didn't make much sense. I was only thinking at GetSystemWow64DirectoryW when I wrote that (which,

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2, resend)

2011-07-28 Thread Paul Vriens
On 07/29/2011 01:29 AM, Octavian Voicu wrote: +else +win_skip("Not on WOW64, skipping test.\n"); Why a win_skip()? Isn't a normal skip() more appropriate? -- Cheers, Paul.

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths. (try 2)

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12984 Your paranoid android

Re: [PATCH] shell32: Disable WOW64 redirection when converting pidls to UNIX paths.

2011-07-28 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=12975 Your paranoid android