Re: [PATCH] quartz: implement AsyncReader_FindPin

2010-08-09 Thread Anton Khirnov
On Sat, Aug 07, 2010 at 11:53:36AM +0200, David Adam wrote: > Hi, > > what about if ppPin is NULL? then it will crash spectacularly, which is exactly what the client throwing around invalid pointers deserves ;) the surrounding code assumes that it's passed valid pointers too. anyway, dshow seems

Re: [PATCH] quartz: implement AsyncReader_FindPin

2010-08-07 Thread David Adam
Hi, what about if ppPin is NULL? I think that this patch needs test cases to prove that it is correct? David 2010/8/6 Anton Khirnov > --- > dlls/quartz/filesource.c | 32 ++-- > 1 files changed, 30 insertions(+), 2 deletions(-) > > diff --git a/dlls/quartz/fileso