Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Reece Dunn
On 24 February 2010 11:41, Alexandre Julliard wrote: > Reece Dunn writes: > >> On 24 February 2010 11:06, Alexandre Julliard wrote: >>> It may be the simplest, but the right way is to add such a test and >>> figure out the appropriate behavior. >> >> Will do -- that was next on my things to do.

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Alexandre Julliard
Reece Dunn writes: > On 24 February 2010 11:06, Alexandre Julliard wrote: >> It may be the simplest, but the right way is to add such a test and >> figure out the appropriate behavior. > > Will do -- that was next on my things to do. > > Do I need to do that first before this change, or after it

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Reece Dunn
On 24 February 2010 11:06, Alexandre Julliard wrote: > Reece Dunn writes: > >> NOTE: A check for integer overflow would be `position.low + move.low < >> position.low`, but there are no current tests to say if integer >> overflow is handled (and how it is handled) here in the tests. >> Therefore,

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams. [try 2]

2010-02-24 Thread Alexandre Julliard
Reece Dunn writes: > NOTE: A check for integer overflow would be `position.low + move.low < > position.low`, but there are no current tests to say if integer > overflow is handled (and how it is handled) here in the tests. > Therefore, the simplest implementation is just to remove the previous >

Re: [PATCH] ole32: ignore HighPart in the Seek method HGLOBAL streams.

2010-02-23 Thread Alexandre Julliard
Reece Dunn writes: > @@ -395,9 +395,11 @@ static HRESULT WINAPI HGLOBALStreamImpl_Seek( > * If the file pointer ends-up after the end of the stream, the next Write > operation will > * make the file larger. This is how it is documented. > */ > - if (dlibMove.QuadPart < 0 && newPosit