Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Peter Beutner
Alexandre Julliard schrieb: > "Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > >> "Peter Beutner" <[EMAIL PROTECTED]> wrote: >>> @@ -148,6 +148,10 @@ LPWSTR WINAPI GetEnvironmentStringsW(void) >>> */ >>> BOOL WINAPI FreeEnvironmentStringsA( LPSTR ptr ) >>> { >>> +/* broken app passes ptr it g

Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Alexandre Julliard
"Dmitry Timoshkov" <[EMAIL PROTECTED]> writes: > "Peter Beutner" <[EMAIL PROTECTED]> wrote: >> @@ -148,6 +148,10 @@ LPWSTR WINAPI GetEnvironmentStringsW(void) >> */ >> BOOL WINAPI FreeEnvironmentStringsA( LPSTR ptr ) >> { >> +/* broken app passes ptr it got from GetEnvironmentStringsW */ >> +

Re: [PATCH] kernel32: return copy of environment blockinGetEnvironmentStringsW

2007-04-05 Thread Dmitry Timoshkov
"Peter Beutner" <[EMAIL PROTECTED]> wrote: Probably an exception handler should be added inside of RtlFreeHeap instead. hm, i vaguely remember reading here that it was prefered not to cover up crashes produced by passing invalid pointers, unless absolutely necessary. If the crash is caused by