Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-03 Thread Francois Gouget
On Sun, 2 Sep 2012, Vincent Povirk wrote: > >> Probably this should be a win_slip(). > > > > The function exists only since Windows 7/Vista (not XP) and is not yet > > in Wine (and might take a while, as my time is limited currently > > and my knowledge of this specific function same). > > > > So

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-02 Thread Vincent Povirk
>> Probably this should be a win_slip(). > > The function exists only since Windows 7/Vista (not XP) and is not yet > in Wine (and might take a while, as my time is limited currently > and my knowledge of this specific function same). > > So I think "skip" is currently the right thing ;) I think a

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-02 Thread Marcus Meissner
On Sun, Sep 02, 2012 at 11:40:52PM +0900, Dmitry Timoshkov wrote: > Marcus Meissner wrote: > > > +if (!pInitializeConditionVariable) { > > +skip("no condition variable support.\n"); > > +return; > > +} > > Probably this should be a win_slip(). The function exists only si

Re: [PATCH] kernel32: add condition variables prototypes and tests (2nd try)

2012-09-02 Thread Dmitry Timoshkov
Marcus Meissner wrote: > +if (!pInitializeConditionVariable) { > +skip("no condition variable support.\n"); > +return; > +} Probably this should be a win_slip(). > +/* fprintf(stderr,"produced %d, c1 %d, c2 %d\n", totalproduced, cnt1, > cnt2); */ > + > +/* The s

Re: [PATCH] kernel32: add condition variables prototypes and tests

2012-09-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21332 Your paranoid android

Re: [PATCH] kernel32: add condition variables prototypes and tests

2012-09-02 Thread Marvin
Hi, While running your changed tests on Windows, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check? Full results can be found at http://testbot.winehq.org/JobDetails.pl?Key=21331 Your paranoid android