Re: [PATCH] gdi32: Don't enumerate font when OpenFontFace fails.

2012-12-06 Thread Qian Hong
Hello, On Thu, Dec 6, 2012 at 3:19 PM, Qian Hong wrote: > Hello, > > On Thu, Dec 6, 2012 at 3:42 PM, Dmitry Timoshkov wrote: >> >> 'face' and 'family' are leaked here. Also returning FALSE at this point >> is too late since both 'face' and 'family' are already in the linked lists. > > Thanks for

Re: [PATCH] gdi32: Don't enumerate font when OpenFontFace fails.

2012-12-05 Thread Qian Hong
Hello, On Thu, Dec 6, 2012 at 3:42 PM, Dmitry Timoshkov wrote: > > 'face' and 'family' are leaked here. Also returning FALSE at this point > is too late since both 'face' and 'family' are already in the linked lists. Thanks for point out this! I'll investigate more. -- Regards, Qian Hong - Sen

Re: [PATCH] gdi32: Don't enumerate font when OpenFontFace fails.

2012-12-05 Thread Dmitry Timoshkov
Qian Hong wrote: > -GetEnumStructs( face, &elf, &ntm, &type ); > +if (!get_enum_structs( face, &elf, &ntm, &type )) return FALSE; > free_family( family ); 'face' and 'family' are leaked here. Also returning FALSE at this point is too late since both 'face' and 'family' are already i