Re: [PATCH] fixed if check before strchr

2008-05-06 Thread Joerg Mayer
On Tue, May 06, 2008 at 10:00:38PM +0200, Eric Pouech wrote: > > spath = strchr(spath, '\\'); > > -if (!spath) spath = strchr(spath, '/'); > > +if (spath) spath = strchr(spath, '/'); So the correct solution would be something like bpath=strchr(spath, '\\'); sp

Re: [PATCH] fixed if check before strchr

2008-05-06 Thread Juan Lang
On Tue, May 6, 2008 at 1:00 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > Marcus Meissner a écrit : >> Hi, >> >> spotted by Coverity (CID 701), a if (!spath) should be if (spath). >> >> Ciao, Marcus >> --- >> programs/winedbg/source.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >

Re: [PATCH] fixed if check before strchr

2008-05-06 Thread James Hawkins
On Tue, May 6, 2008 at 3:00 PM, Eric Pouech <[EMAIL PROTECTED]> wrote: > Marcus Meissner a écrit : > > > > Hi, > > > > spotted by Coverity (CID 701), a if (!spath) should be if (spath). > > > > Ciao, Marcus > > --- > > programs/winedbg/source.c |2 +- > > 1 files changed, 1 insertions(+

Re: [PATCH] fixed if check before strchr

2008-05-06 Thread Eric Pouech
Marcus Meissner a écrit : > Hi, > > spotted by Coverity (CID 701), a if (!spath) should be if (spath). > > Ciao, Marcus > --- > programs/winedbg/source.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/programs/winedbg/source.c b/programs/winedbg/source.c > index 551