Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 02:25 PM, Reece Dunn wrote: On 24 July 2010 16:10, Max TenEyck Woodbury wrote: On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:34 PM, Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 01:55 PM, James McKenzie wrote: Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of w

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Max TenEyck Woodbury wrote: On 07/25/2010 01:55 PM, James McKenzie wrote: Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug fo

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Alexandre Julliard
James McKenzie writes: > Also, strongly defending your patches without authoritative > information marks you as being arrogant. After a while, your patches > will be ignored. That is not a good place to be in this project. Your habit of pretending to be an authority in the project, when you cl

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Reece Dunn
On 24 July 2010 16:10, Max TenEyck Woodbury wrote: > On 07/24/2010 10:58 AM, Nikolay Sivov wrote: >> >> On 7/24/2010 18:51, Max TenEyck Woodbury wrote: >>> >>> --- >>> dlls/ntdll/file.c | 5 + >>> 1 files changed, 5 insertions(+), 0 deletions(-) >>> >>> diff --git a/dlls/ntdll/file.c b/dlls/ntd

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Andrew Eikum wrote: On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does Windows return "STATUS_N

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Andrew Eikum
On 07/25/2010 12:04 PM, Max TenEyck Woodbury wrote: On 07/25/2010 09:45 AM, James McKenzie wrote: I think you missed what Nicolay and Dmitry are trying to tell you. We are trying to implement, bug for bug, the functionality of what Windows does. Does Windows return "STATUS_NOT_IMPLEMENTED" when

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread Max TenEyck Woodbury
On 07/25/2010 09:45 AM, James McKenzie wrote: Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-25 Thread James McKenzie
Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6 +2148,11 @@ NTSTATUS WINAPI NtSetInformati

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Max TenEyck Woodbury
On 07/25/2010 12:50 AM, Dmitry Timoshkov wrote: Max TenEyck Woodbury wrote: + /* Invalid requests - do not need 'fixing'. */ + case FileAllInformation: + io->u.Status = STATUS_NOT_IMPLEMENTED; + break; + default: FIXME("Unsupported class (%d)\n", class); io->u.Status = STATUS_NOT_IMPLEMENTED;

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Dmitry Timoshkov
Max TenEyck Woodbury wrote: > >> + /* Invalid requests - do not need 'fixing'. */ > >> + case FileAllInformation: > >> + io->u.Status = STATUS_NOT_IMPLEMENTED; > >> + break; > >> + > >> default: > >> FIXME("Unsupported class (%d)\n", class); > >> io->u.Status = STATUS_NOT_IMPLEMENTED; > > Add a t

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Max TenEyck Woodbury
On 07/24/2010 10:58 AM, Nikolay Sivov wrote: On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c | 5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll

Re: [PATCH] dlls/ntdll/file.c: Setting FileAllInformation is not 'fixable'.

2010-07-24 Thread Nikolay Sivov
On 7/24/2010 18:51, Max TenEyck Woodbury wrote: --- dlls/ntdll/file.c |5 + 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/dlls/ntdll/file.c b/dlls/ntdll/file.c index 0a6ee55..86c200f 100644 --- a/dlls/ntdll/file.c +++ b/dlls/ntdll/file.c @@ -2148,6 +2148,11 @@ NTSTATU