Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName. (try 5) (resend)

2012-05-09 Thread Alexandre Julliard
Christian Costa writes: > Try 5: Use a growing buffer to store name. I don't think a growing buffer makes sense for this. > +if (name) > +{ > +*size = min(*size, This->name_size); > +memcpy(name, This->name, *size); > +/* Make sure we have the terminating 0 in ca

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.

2012-04-04 Thread Christian Costa
Le 04/04/2012 21:24, Henri Verbeet a écrit : You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from? Indeed 128 is inapropriate. A dynamic allocation is much better. I will resubmit a patch. Thanks.

Re: [PATCH] d3drm: Retreive mesh name at loading time. Implement GetName and SetName.

2012-04-04 Thread Henri Verbeet
You should use debugstr_a() for printing strings like that. Also, where does the 128 char limit come from?