"Detlef Riekenberg" wrote:
> >> + /* win8: E_NOTIMPL */
> >> + ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);
>
> >A usual form for such comparisons is
> >ok(hr == E_FAIL || hr == E_NOTIMPL /* win8 */, "got 0x%08x.\n", hr);
> I disagree!
>
> Comments at the end of a line are ok,
> bu
It probably makes sense to marking old one as broken, as E_NOTIMPL sounds
better in this case. This could potentially break things of course if
application checks for strict equality of the error code.
On Thu, Dec 13, 2012 at 8:02 AM, Detlef Riekenberg wrote:
> winetestbot crash sometimes in co
Detlef Riekenberg wrote:
> -ok(hr == E_FAIL, "got 0x%08x.\n", hr);
> +/* win8: E_NOTIMPL */
> +ok(hr == E_FAIL || hr == E_NOTIMPL, "got 0x%08x.\n", hr);
A usual form for such comparisons is
ok(hr == E_FAIL || hr == E_NOTIMPL /* win8 */, "got 0x%08x.\n", hr);
that helps
