Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-07 Thread Christian Costa
Yes. It is adressed in the next serie I just sent. Christian > Message du 07/09/11 08:34 > De : "Frédéric Delanoy" > A : "Christian Costa" > Copie à : "Wine Devel" > Objet : Re: [PATCH] attrib: Move implementation from cmd.exe to the >

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-06 Thread Frédéric Delanoy
"help attrib" from within cmd, and "wine attrib /?" give different results. That should probably be aligned, for better integration, if possible. Frédéric.

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-06 Thread Frédéric Delanoy
> I don't have such an error here. Are you sure it is my patch that causes > this ? > Line 591 does not say much. Is it in the .cmd file or the .cmd.exp one. What > is the failing command ? > I don't see the point with testbot, there is no tests change in my patch. Don't have the error anymore, pr

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-06 Thread Christian Costa
On 06/09/2011 15:33, Frédéric Delanoy wrote: On Tue, Sep 6, 2011 at 09:35, Christian Costa wrote: -- It's just a resend. The patch is unmodified, just rebased on latest git. try4: - add missing NULL ending character to help_option string try3: - fix /? option. This fixes cmd tests regression

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 4) (resend)

2011-09-06 Thread Frédéric Delanoy
On Tue, Sep 6, 2011 at 09:35, Christian Costa wrote: > -- > > It's just a resend. The patch is unmodified, just rebased on latest git. > > try4: > - add missing NULL ending character to help_option string > > try3: > - fix /? option. This fixes cmd tests regression > > try2: > - keep attrib infos

re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command (try 2)

2011-08-27 Thread Dan Kegel
Hi Christian, your patch causes test failures in programs/cmd/tests here: ... batch.c:301: Test failed: unexpected char 0x41 position 0 in line 545 (got 'ATTRIB - Displays or changes file attributes.', wanted 'not-r.test not found after delete, good') batch.c:295: Test failed: unexpected end of lin

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command

2011-08-24 Thread Frédéric Delanoy
2011/8/24 Frédéric Delanoy : > On Wed, Aug 24, 2011 at 08:20, Christian Costa wrote: >> -- >> >> I added a stub last year to make an installer work but didn't know the >> command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So >> here is a patch that takes what's in cmd.exe an

Re: [PATCH] attrib: Move implementation from cmd.exe to the standalone command

2011-08-23 Thread Frédéric Delanoy
On Wed, Aug 24, 2011 at 08:20, Christian Costa wrote: > -- > > I added a stub last year to make an installer work but didn't know the > command existed as a builtin in cmd.exe until Frédéric Delanoy told me. So > here is a patch that takes what's in cmd.exe and move it to the standalone > comma