Re: [PATCH] activeds: Exclude unused headers.

2013-03-12 Thread Alexandre Julliard
Amine Khaldi writes: > In this case ending up with windows.h is not needed, so if we: > > #define WIN32_NO_STATUS > #define _INC_WINDOWS > #define COM_NO_WINDOWS_H > > That prevents it. > > Should I send a second patch with these defines ? No, that's ugly, particularly the _INC_WINDOWS one. --

Re: [PATCH] activeds: Exclude unused headers.

2013-03-12 Thread Amine Khaldi
On 12/03/2013 11:27, Alexandre Julliard wrote: > Amine Khaldi writes: > >> @@ -28,13 +28,10 @@ >> >> #include "windef.h" >> #include "winbase.h" >> -#include "winuser.h" >> >> #include "objbase.h" >> #include "iads.h" >> -#include "adshlp.h" >> >> -#include "wine/unicode.h" >> #include

Re: [PATCH] activeds: Exclude unused headers.

2013-03-12 Thread Alexandre Julliard
Amine Khaldi writes: > @@ -28,13 +28,10 @@ > > #include "windef.h" > #include "winbase.h" > -#include "winuser.h" > > #include "objbase.h" > #include "iads.h" > -#include "adshlp.h" > > -#include "wine/unicode.h" > #include "wine/debug.h" It's not worth the trouble, particularly since