On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote:
> Like Henri already said, you really can't use globals for anih,
> ani_frames, and ani_frame_idx. These should be in a structure, and
> decodeRIFF should write into that structure, not into globals. The
> structure should then be associated with t
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote:
> For ease of review, you should send one cumulative patch, rather than
> patches that apply on top of one another. (I use separate git trees -
> one for development, one for merging - to make this easier.) The
> style fixes at least look good thou
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote:
> That doesn't make it better, it's not thread-safe. Pass them as
> parameters to decodeRIFF.
Ahh, I see. Yes, fixed.
> I still say a symbolic constant is better, or at the least, a comment.
> A test case that shows that it's needed is even bett
On 8/29/07, Juan Lang <[EMAIL PROTECTED]> wrote:
> This doesn't belong with this patch.
Yes, sorry.
> One more random piece of advice: this has gotten enough commentary
> that it may very well have entered Alexandre's "ignore for a while"
> queue. So if you don't have success with this, wait so
--- a/dlls/imm32/imm.c
+++ b/dlls/imm32/imm.c
@@ -1505,7 +1505,8 @@ BOOL WINAPI ImmRegisterWordW(
*/
BOOL WINAPI ImmReleaseContext(HWND hWnd, HIMC hIMC)
{
- FIXME("(%p, %p): stub\n", hWnd, hIMC);
+if (hIMC == (HIMC)root_context)
+root_context->IMC.hWnd = NULL;
This doesn't belong
> > Like Henri already said, you really can't use globals for anih,
> > ani_frames, and ani_frame_idx. These should be in a structure, and
> > decodeRIFF should write into that structure, not into globals. The
> > structure should then be associated with the icon.
>
> They're temps.. I've added a
On 28/08/07, Juan Lang <[EMAIL PROTECTED]> wrote:
> This may be obvious to other, but certainly not to me: what does
> 0x0003 mean? You need to use symbolic constants here.
>
It's a version number.
> Ok, attached, and fixed an issue with setting delay on the last frame.
+static ANIHEADER *anih;
+static LPBYTE *ani_frames;
+static DWORD ani_frame_idx;
+
+static void decodeRIFF(LPBYTE bytes, DWORD size)
+{
+CK *chunk = (CK*)bytes;
+CKSIZE sizeWithPad = chunk->ckSize % 2 ? chunk->ckSize
I've fixed the style issues indicated.
I'm now using Xcursor's animated cursor support.
The delay information in the ANI is honored.
The changes to struct tagCURSORICONINFO are removed and, instead, I'm
appending data after the bitmap info.. so Paint Brush can continue
manipulating those bits di
I noticed LoadCursorFromFile() wasn't working, so here's a patch to fix that.
And a patch to fix some memory I was leaking.
Have tested 150+ animated cursors so far, all appear to display correctly.
Trent
From 969a78da805d267ac5abc6427e017e4f6e3fec18 Mon Sep 17 00:00:00 2001
From: Trent Waddingt
On 8/28/07, H. Verbeet <[EMAIL PROTECTED]> wrote:
> http://repo.or.cz/w/wine/hacks.git?a=blob;f=dlls/winex11.drv/mouse.c;h=b344335f485aca6f6b37cfde5099c556f7dbdd73;hb=e69f5034c725353f1d23f7df6a2ce6ef3ad58412#l514
> should be a decent start.
heh, making me think this is a well beaten path.
> Well,
For ease of review, you should send one cumulative patch, rather than
patches that apply on top of one another. (I use separate git trees -
one for development, one for merging - to make this easier.) The
style fixes at least look good though.
--Juan
On 28/08/07, Trent Waddington <[EMAIL PROTECTED]> wrote:
> On 8/28/07, H. Verbeet <[EMAIL PROTECTED]> wrote:
> > You should use the timing and frame sequence info from the .ani.
> > Also, Xcursor actually supports proper animated cursors, so it would
> > be better to handle the animation in winex11
On 27/08/07, Trent Waddington <[EMAIL PROTECTED]> wrote:
> +ANIHEADER *anih = NULL;
> +LPBYTE *ani_frames = NULL;
> +DWORD ani_frame_idx = 0;
I don't think you want to be using global variables for that.
> -USER_Driver->pSetCursor(
> (CURSORICONINFO*)GlobalLock16(HCURSOR_16(hCursor)) );
>
Hi Trent, thanks for the patch. Generally cc'ing wine-devel isn't
necessary unless you have a specific question.
+// functions for decoding animated cursors
No C++-style comments, please.
+//DWORD form = *(DWORD*)chunk->ckData;
Dead code should be omitted rather than commented
Test program at:
http://rtfm.insomnia.org/~qg/animatedcursor.exe
Probably doesn't support all the possible animated cursors supported
under windows, and correct timing of animation hasn't been attempted.
Trent
From 760d2556e1f3ce4123b500ffc4f6d141cfcbca03 Mon Sep 17 00:00:00 2001
From: Trent
16 matches
Mail list logo
