Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

2009-12-23 Thread Steven Edwards
Hi Dmitry, On Thu, Dec 24, 2009 at 2:21 AM, Dmitry Timoshkov wrote: > Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch > much smaller. Also avoiding useless typedef, making WineFile_OnRun() static, > using correct casts, avoiding hungarian notation and magic flags would m

Re: [PATCH] Replace builtin WineFile Execute Dialog with standard RunFileDialog

2009-12-23 Thread Dmitry Timoshkov
"Steven Edwards" wrote: - Removed the LoadLibrary calls in favor of GetModuleHandle as suggested by Paul Vriens - Match the bad formating of the rest of the file Avoiding a needless renaming of ID_EXECUTE to ID_RUN would make the patch much smaller. Also avoiding useless typedef, making WineF