Re: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Alexandre Julliard
Andrey Turkin <[EMAIL PROTECTED]> writes: > It is not used in the function itself, it is only passed to > user-provided callback. So, I see several possibilities: I know it's in the callback, what I meant is that the ntdll function should not be taking a LPOVERLAPPED_COMPLETION_ROUTINE, which is

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Andrey Turkin
Alexandre Julliard wrote: > Robert Shearman <[EMAIL PROTECTED]> writes: > > >> Andrey Turkin wrote: >> >>> Robert Shearman wrote: >>> >>> Andrey Turkin wrote: > > /**

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Alexandre Julliard
Robert Shearman <[EMAIL PROTECTED]> writes: > Andrey Turkin wrote: >> Robert Shearman wrote: >> >>> Andrey Turkin wrote: >>> /** *BindIoCompletionCallback (KERNEL32.@) */

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Robert Shearman
Andrey Turkin wrote: > Robert Shearman wrote: > >> Andrey Turkin wrote: >> >>> >>> /** >>> >>> *BindIoCompletionCallback (KERNEL32.@) >>> */ >>> +extern NTSTATUS WINAPI >>> RtlSetIoCompletionCallback(H

RE: [PATCH] Implement BindIoCompletionCallback

2007-12-19 Thread Rolf Kalbermatter
Andrey Turkin wrote: >diff --git a/dlls/kernel32/tests/sync.c b/dlls/kernel32/tests/sync.c >index e402fed..7bbb3e2 100644 >--- a/dlls/kernel32/tests/sync.c >+++ b/dlls/kernel32/tests/sync.c >@@ -327,7 +327,7 @@ static void test_iocp_callback(void) > retb = p_BindIoCompletionCallback(hFile, ioc

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-18 Thread Steven Edwards
On Dec 18, 2007 3:49 PM, Andrey Turkin <[EMAIL PROTECTED]> wrote: > winternl.h may not depend on winbase.h for some reason, so this would > mean either changing prototype to "(HANDLE,LPVOID,ULONG)", which seems > wrong, or redefining LPOVERLAPPED_COMPLETION_ROUTINE and > OVERLAPPED/LPOVERLAPPED, wh

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-18 Thread Andrey Turkin
Robert Shearman wrote: > Andrey Turkin wrote: >> >> /** >> >> *BindIoCompletionCallback (KERNEL32.@) >> */ >> +extern NTSTATUS WINAPI >> RtlSetIoCompletionCallback(HANDLE,LPOVERLAPPED_COMPLETION_ROUTINE,ULONG)

Re: [PATCH] Implement BindIoCompletionCallback

2007-12-18 Thread Robert Shearman
Andrey Turkin wrote: > > /** > * BindIoCompletionCallback (KERNEL32.@) > */ > +extern NTSTATUS WINAPI > RtlSetIoCompletionCallback(HANDLE,LPOVERLAPPED_COMPLETION_ROUTINE,ULONG); > This should go in wint