On 09/07/10 14:22, Dan Kegel wrote:
> Thanks for sending that patch.
>
> It seems your editor stripped whitespace from the ends of lines,
> causing three whitespace-only hunks on the end of your patch.
> Please don't do that; Wine deveopers frown on unrelated whitespace changes.
>
> You might hav
On Fri, Jul 9, 2010 at 1:04 PM, Eliot Blennerhassett
wrote:
> Now I see that revised patch 63334 is in "Needs Tests" state, I'm not a
> windows application developer...
>
> I am not able to write any new test for this.
>
> There are already 52 uses of EndDialog in dlls/user32/tests
> If these stil
Hi Dan,
thanks for your response.
On 09/07/10 14:22, Dan Kegel wrote:
> Thanks for sending that patch.
>
> It seems your editor stripped whitespace from the ends of lines,
Having one's editor take care of trailing whitespace is fairly standard
practice isn't it?
Can I guess that having trailin
If you are saying they won't accept a patch because of this, I'd be
tempted to say "for f**ks sake can I be bothered with such pettiness?",
but I suppose "for the greater good" I'd resubmit.
It is common behaviour for large scale projects, e.g. the Linux Kernel
applies this rule, too. If you fr
On Thu, Jul 8, 2010 at 7:50 PM, Eliot Blennerhassett
wrote:
>> It seems your editor stripped whitespace from the ends of lines,
>
> Having one's editor take care of trailing whitespace is fairly standard
> practice isn't it?
Not when working on Wine code.
> Can I guess that having trailing white
Thanks for sending that patch.
It seems your editor stripped whitespace from the ends of lines,
causing three whitespace-only hunks on the end of your patch.
Please don't do that; Wine deveopers frown on unrelated whitespace changes.
You might have better luck getting your change in if you includ
