Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters

2008-05-20 Thread Michael Karcher
Am Montag, den 19.05.2008, 19:58 +0900 schrieb Dmitry Timoshkov: > "Michael Karcher" <[EMAIL PROTECTED]> wrote: > > > +INT WINAPI StringFromGUID2_16(REFGUID id, LPSTR str, INT cmax) > > +{ > > + char xguid[80]; > > + int len; > > + > > + if (WINE_StringFromCLSID( id, xguid )) > > + r

Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters

2008-05-19 Thread Michael Karcher
Am Montag, den 19.05.2008, 20:41 +0900 schrieb Dmitry Timoshkov: > "Michael Karcher" <[EMAIL PROTECTED]> wrote: > > http://msdn.microsoft.com/en-us/library/ms683893(VS.85).aspx > > says so. I will test Microsoft's native implementation when I get around > > to. > That's the description of 32-bit im

Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters

2008-05-19 Thread Michael Karcher
Am Montag, den 19.05.2008, 19:58 +0900 schrieb Dmitry Timoshkov: > > +INT WINAPI StringFromGUID2_16(REFGUID id, LPSTR str, INT cmax) > > +{ > > + char xguid[80]; > > + int len; > > + > > + if (WINE_StringFromCLSID( id, xguid )) > > + return 0; > > + > > + len = strlen( xguid ) + 1;

Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters

2008-05-19 Thread Dmitry Timoshkov
"Michael Karcher" <[EMAIL PROTECTED]> wrote: >> This is not an equivalent of the old implementation, is it really >> supposed to fail if the buffer length is shorter than the guid? > > http://msdn.microsoft.com/en-us/library/ms683893(VS.85).aspx > says so. I will test Microsoft's native implement

Re: [PATCH] Fix 16 bit StringFromGUID2 to not use wide characters

2008-05-19 Thread Dmitry Timoshkov
"Michael Karcher" <[EMAIL PROTECTED]> wrote: > +INT WINAPI StringFromGUID2_16(REFGUID id, LPSTR str, INT cmax) > +{ > + char xguid[80]; > + int len; > + > + if (WINE_StringFromCLSID( id, xguid )) > + return 0; > + > + len = strlen( xguid ) + 1; /* The terminating zero counts */ >