Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Scott Lindeneau
The async bug was revealed as I was writing the acceptex tests. The only observable effect was a thread hanging because it never gets notified. I don't know how/where to write conformance tests for the wineserver core. > If you can write a conformance test to expose the bug, > then please send that

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Dan Kegel
Scott Lindeneau <[EMAIL PROTECTED]> wrote: > The problem was related to a bug in the > wineserver async implementation that appeared when a file descriptor > handled its own polling events (like sockets) and garbage collection. > Fixing the bug fixes the problem i was having earlier. Should I > inc

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Juan Lang
> Ah. My apologies. My question was related to writing the > implementation of acceptex. I have recently solved the problem and the > question is now moot. The problem was related to a bug in the > wineserver async implementation that appeared when a file descriptor > handled its own polling events

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Scott Lindeneau
> ?? Not sure what you're talking about there. Your tests > should not try to get at any hidden Wine info. They > should simply use plain old Windows networking calls > that should not complicate the wineserver. > - Dan Ah. My apologies. My question was related to writing the implementation of

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Dan Kegel
Scott Lindeneau <[EMAIL PROTECTED]> wrote: > Is an emulated environment using qemu good enough? Yes, for networking stuff it'd be just fine. >>>If anyone can tell me how to check to see if there are connections >>>pending on a sockets listen backlog (in the wineserver) and how to >>>post that in

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Austin English
On Wed, Aug 20, 2008 at 7:48 AM, Scott Lindeneau <[EMAIL PROTECTED]> wrote: > On Tue, Aug 19, 2008 at 9:15 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: >> Scott Lindeneau <[EMAIL PROTECTED]> wrote: >>> i Don't have any windows machines to test the code on >> >> That's a real problem. You can't be sur

Re: [PATCH] AcceptEx Impelementation

2008-08-20 Thread Scott Lindeneau
On Tue, Aug 19, 2008 at 9:15 AM, Dan Kegel <[EMAIL PROTECTED]> wrote: > Scott Lindeneau <[EMAIL PROTECTED]> wrote: >> i Don't have any windows machines to test the code on > > That's a real problem. You can't be sure the tests you're > writing are good unless they pass on a windows machine. Is a

Re: [PATCH] AcceptEx Impelementation

2008-08-18 Thread Dan Kegel
Scott Lindeneau <[EMAIL PROTECTED]> wrote: > i Don't have any windows machines to test the code on That's a real problem. You can't be sure the tests you're writing are good unless they pass on a windows machine. That said, simple tests are better than no tests, and if you can find somebody to

Re: [PATCH] AcceptEx Impelementation

2008-08-18 Thread Scott Lindeneau
Date: Mon, 4 Aug 2008 05:20:43 -0700 From: "Dan Kegel" <[EMAIL PROTECTED]> >2) port some existing accept() conformance tests from ws2_32/tests/sock.c >to use AcceptEx(), add a bit to check the special new features, >and make sure they pass on Windows. On Sun, Aug 10, 2008 at 4:16 PM, Kai Blin <[EM

Re: [PATCH] AcceptEx Impelementation

2008-08-10 Thread Kai Blin
Hi Scott, I didn't see a reply to your AcceptEx patches yet, sorry if I missed it and you get this again. Please submit one patch per email only. I admittedly don't know much about the wineserver stuff, but I've noticed a couple of style issues in the winsock code: The indentation common in s

re: [PATCH] AcceptEx Impelementation

2008-08-04 Thread Dan Kegel
Hi Scott! Three suggestions: 1) send one patch per email; use 1/2 and 2/2 in the subject line to make it clear they're related 2) port some existing accept() conformance tests from ws2_32/tests/sock.c to use AcceptEx(), add a bit to check the special new features, and make sure they pass on Windows