Re: [MSVCRT] Cross build fix

2004-06-03 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > However, I did grep the source, and it seems that we're using the > MSVCRT_ prefix only in dlls/msvcrt/*.c. And so it's not clear to > me that duplicating part of the headers is going to be that bad. > I mean, we will need duplication only for the s

Re: [MSVCRT] Cross build fix

2004-06-03 Thread Dimitrie O. Paun
On Wed, Jun 02, 2004 at 11:09:36AM -0700, Alexandre Julliard wrote: > I don't see how this would solve problems like the _WCTYPE_T_DEFINED > issue. Right, it will not solve problems like this (for Boaz: _WCTYPE_T_DEFINED is a sentry for not defining a type twice, check out pretty much any header u

Re: [MSVCRT] Cross build fix

2004-06-02 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: >> When compiling with STLPort I saw a method that can eliminate the need >> for the MSVCRT macro and yet produce MSVCRT_xxx for those who need it >> and an xxx for those how don't. >> Basically you have your Regular cleanroom headers-set for wine

Re: [MSVCRT] Cross build fix

2004-06-02 Thread Dimitrie O. Paun
> When compiling with STLPort I saw a method that can eliminate the need > for the MSVCRT macro and yet produce MSVCRT_xxx for those who need it > and an xxx for those how don't. > Basically you have your Regular cleanroom headers-set for wine-lib and > external dlls. And you have another set

Re: [MSVCRT] Cross build fix

2004-06-02 Thread Boaz Harrosh
Dimitrie O. Paun wrote: On Tue, Jun 01, 2004 at 11:16:06AM -0700, Alexandre Julliard wrote: No I don't think we want that. The headers are not that stable, we are still making changes to them. We also need the MSVCRT definitions in multiple dlls so there would be a lot of duplication. Yes,

Re: [MSVCRT] Cross build fix

2004-06-01 Thread Dimitrie O. Paun
On Tue, Jun 01, 2004 at 11:16:06AM -0700, Alexandre Julliard wrote: > No I don't think we want that. The headers are not that stable, we are > still making changes to them. We also need the MSVCRT definitions in > multiple dlls so there would be a lot of duplication. Yes, the headers are not stabl

Re: [MSVCRT] Cross build fix

2004-06-01 Thread Alexandre Julliard
"Dimitrie O. Paun" <[EMAIL PROTECTED]> writes: > Alexandre, why don't we just remove all those MSVCRT() macros, > use the headers in Winelib apps, and duplicate what we need > with a MSVCRT_ prefix in an internal header that we use just > for building? These things are quite stable, so the risk of

Re: [MSVCRT] Cross build fix

2004-06-01 Thread Dimitrie O. Paun
On Tue, Jun 01, 2004 at 11:42:28AM +0200, Hans Leidekker wrote: > > Hi, > > This patch: > > http://www.winehq.org/hypermail/wine-cvs/2004/04/0357.html > > broke the MinGW build of msvcrt. The changelog says it's a compatibility > fix. Dimi: what compatibility were you aiming at with this patc